feat: Support conforming singer property names to target identifier constraints in SQL sinks #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 4, 2022 15:49
|
@aaronsteers @edgarrmondragon here is my first-pass attempt at column name conforming. The new "SampleTapHostile" tests are passing, and I think cover most of the common DBMS identifier constraints. Let me know what you think of the overall approach, and if there are other test cases worth adding 👍 |
edgarrmondragon
requested changes
Oct 6, 2022
edgarrmondragon
requested changes
Oct 7, 2022
Co-authored-by: Edgar R. M. <[email protected]>
Co-authored-by: Edgar R. M. <[email protected]>
Co-authored-by: Edgar R. M. <[email protected]>
Co-authored-by: Edgar R. M. <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1039 +/- ##
==========================================
+ Coverage 83.39% 83.43% +0.03%
==========================================
Files 39 40 +1
Lines 3758 3815 +57
Branches 628 642 +14
==========================================
+ Hits 3134 3183 +49
- Misses 464 471 +7
- Partials 160 161 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
requested changes
Oct 12, 2022
edgarrmondragon
approved these changes
Oct 13, 2022
aaronsteers
approved these changes
Oct 13, 2022
kgpayne
force-pushed
the
kgpayne/issue1021
branch
from
3f9aa9e to
2721dc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1021
📚 Documentation preview 📚: https://meltano-sdk--1039.org.readthedocs.build/en/1039/